error in the code

hi Sergey,
i found an error in the code in install.php, in the admin folder:

when the istallation of the gamepack starts, the for loop runs through the queries, and if one fails in turns $success into false.
problem is - the check afterwards is:

Code:

if( !success )

this should be:

Code:

if( !$success )

also, i think it would be helpfull to preg_match the names of the games not instralled, and display them in the ERROR msg, so that it would be easier to find the problem.

Amit

i forgot to add - this is my basic addition to the script - i think it's a lot easier this way

$falseQueries = array();
foreach( $queries as $query )
            {
               $slen .= strlen($query) . " - ";
               if( strlen($query) > 10 )
               {
                  if( !$db->query($query, 0) )
                  {
                     $success = false;
                     $falseQueries[] = $query;
                  }
                  else
                  {
                     $nqueriesleft--;
                     $ninstalled++;
                  }
               }
            }
            if( !$success )
               {
                  $failQs = implode('<br />',$falseQueries);
                  $tpl->assign( "ERROR", "An error occured while adding new records to the database.<br /><br />Un-installed queries:<br />$failQs" );
               }

thank you very much for informing me about that error (fortunately it's not critical), I've corrected the file in both versions - 1.2 which is on the site and 1.3 which I'm working on... As for your suggestion in the second post, it looks good, I'll most likely add those changes in PAS v1.3.